-
Notifications
You must be signed in to change notification settings - Fork 12
Set timeout for all actions #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tim-schilling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plan and Apply are very similar. I think we should use the same timeout. I don't think it should be more than 10, 5 may be a bit too short, but I could agree to it. I put suggestions to settle on 10 as more conservative, but I'll likely switch to your opinion @ulgens if you have a strong preference.
django-commons#359 (comment) Co-authored-by: Tim Schilling <schilling711@gmail.com>
django-commons#359 (comment) Co-authored-by: Tim Schilling <schilling711@gmail.com>
|
@tim-schilling I committed both of your suggestions. We can "squash merge" the PR at the end. I don't have a strong opinion on the values; I'm actually a bit lost about them.
and I'm not sure if any of these analyses are actually important 😬 I tend to set a limit with a logic that "if something takes a certain percentage longer than average, it should be timed out" but even if we use a global value like 15m, I'm not sure there would be any harm. |
|
I may need to rebase/squash these so my name is associated with them. There's a bug in the plan action 🫠 |
e76c404 to
a7457bd
Compare
|
Nope, that wasn't it. Sorry @ulgens if this gets a little noisy. |
Co-authored-by: Tim Schilling <schilling711@gmail.com>
dfa7863 to
f61c3b0
Compare
|
I think this won't run plan since it does not have access to the TF github token secret. |
|
@cunla any ideas on why it doesn't? |
|
Ah, because it's a fork, not the actual branch. Hmmm |
I think we want to keep it that way, otherwise forks will have access to the github_token. |
Coming from #356 (comment)
I checked the average runtimes from https://github.com/django-commons/membership/actions/metrics/performance and tried to set meaningful but not too strict limits. Please let me know if you think the values should be updated.